Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global rate limiting: support header value matches #3599

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

skriss
Copy link
Member

@skriss skriss commented Apr 20, 2021

Adds support for Envoy's HeaderValueMatch rate limit action
which generates descriptor entries based on match criteria
for the request's headers.

Closes #3595.

Signed-off-by: Steve Kriss krisss@vmware.com

Adds support for Envoy's HeaderValueMatch rate limit action
which generates descriptor entries based on match criteria
for the request's headers.

Closes projectcontour#3595.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner April 20, 2021 17:13
@skriss skriss requested review from danehans and sunjayBhatia and removed request for a team April 20, 2021 17:13
@skriss
Copy link
Member Author

skriss commented Apr 20, 2021

Note, support for notpresent header matching to follow in a separate PR (https://github.com/skriss/contour/tree/header-match-notpresent)

@skriss skriss added this to the 1.15.0 milestone Apr 20, 2021
@skriss skriss added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #3599 (c4a106d) into main (c415e36) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head c4a106d differs from pull request most recent head c5fa17e. Consider uploading reports for the commit c5fa17e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3599      +/-   ##
==========================================
+ Coverage   76.58%   76.70%   +0.11%     
==========================================
  Files         100      100              
  Lines        7030     7052      +22     
==========================================
+ Hits         5384     5409      +25     
+ Misses       1530     1527       -3     
  Partials      116      116              
Impacted Files Coverage Δ
internal/dag/dag.go 96.93% <ø> (ø)
internal/dag/conditions.go 95.69% <100.00%> (+0.14%) ⬆️
internal/dag/policy.go 93.06% <100.00%> (+0.18%) ⬆️
internal/envoy/v3/ratelimit.go 100.00% <100.00%> (ø)
internal/k8s/log.go 69.56% <0.00%> (+6.52%) ⬆️

@skriss skriss merged commit 7a161de into projectcontour:main Apr 21, 2021
Contour Project Board automation moved this from 1.15 release (WIP) to 1.14 release completed Apr 21, 2021
@skriss skriss deleted the rl-header-match branch April 22, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global rate limiting: support envoy HeaderValueMatch action
3 participants