internal/status: Update HTTPRoute status to only allow a single Type #3600
Conversation
stevesloka
requested review from
sunjayBhatia and
youngnick
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 76.65% 76.63% -0.03%
==========================================
Files 100 100
Lines 7039 7044 +5
==========================================
+ Hits 5396 5398 +2
- Misses 1527 1530 +3
Partials 116 116
|
|
integration tests are failing, not sure why, need to dig into that. |
|
Ok this should all be fixed up. =) |
| Value: "/", | ||
| }, | ||
| }}, | ||
| ForwardTo: []gatewayapi_v1alpha1.HTTPRouteForwardTo{{ |
There was a problem hiding this comment.
In the case that these two rules are in the reverse order, do we expect the condition message to be Service "invalid-two" does not exist, Service "invalid-one" does not exist
Would there be value in ensuring the order of the parts of the message are sorted for comparisons between existing and potentially updated status?
There was a problem hiding this comment.
Yeah I'd expect if you reverse the order the messages would be swapped.
if there was an existing condition with the same Type and something got added, it should get recreated from scratch so I'd expect the order to be consistent, unless I'm misunderstanding.
Updates the HTTPRoute status processing to only allow a single "Type" to be specified at any given time. If there are duplicate conditions for the same type, then the messages are appended together. Fixes projectcontour#3534 Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
Updates the HTTPRoute status processing to only allow a single "Type" to
be specified at any given time. If there are duplicate conditions for the same
type, then the messages are appended together.
Fixes #3534
Signed-off-by: Steve Sloka slokas@vmware.com