internal/dag: Filter on Gateway.Listener.Protocol for supported types #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
requested review from
danehans and
skriss
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3612 +/- ##
==========================================
+ Coverage 76.66% 76.69% +0.02%
==========================================
Files 100 100
Lines 7066 7075 +9
==========================================
+ Hits 5417 5426 +9
+ Misses 1533 1532 -1
- Partials 116 117 +1
|
Filters the Protocol on gateway listeners for only valid types (e.g. HTTP, HTTPS, TLS). Fixes projectcontour#3540 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
filterListenerProtocol
branch
from
2f2950d
to
0ec52fe
Compare
internal/dag/builder_test.go
Outdated
| Spec: gatewayapi_v1alpha1.GatewaySpec{ | ||
| Listeners: []gatewayapi_v1alpha1.Listener{{ | ||
| Port: 443, | ||
| Protocol: gatewayapi_v1alpha1.HTTPProtocolType, // <--- invalid protocol, must be "HTTPS" |
There was a problem hiding this comment.
is this comment removable/movable to the below test case?
There was a problem hiding this comment.
or maybe the test case names got mixed up? looking at the full file it looks like this test case is actually "insert basic single route, single hostname, gateway with TLS, invalid listener protocol"
There was a problem hiding this comment.
I'll remove the comment since now the protocol is ignored in relation to if tls is defined or not.
Signed-off-by: Steve Sloka <slokas@vmware.com>
skriss
requested changes
Apr 26, 2021
Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
sunjayBhatia
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters the Protocol on gateway listeners for only valid types (e.g. HTTP, HTTPS, TLS).
Fixes #3540
Signed-off-by: Steve Sloka slokas@vmware.com