internal/dag: Remove Ingress v1beta1 #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjayBhatia
requested review from
stevesloka and
youngnick
and removed request for
a team
sunjayBhatia
added
release-note
|
Converted to draft b/c this package refactor relies on others |
|
added release note labels because this will make Contour unusable in versions of k8s that do not have ingress v1, as we're no longer falling back to v1beta1 |
- Removes v1beta1 tests
- Removes v1beta1 Ingress insertion/deletion from cache
- Note: This will mean k8s pre-1.19 will stop working with Ingress
v1beta1 since Ingress v1 does not exist yet in those versions
Updates: projectcontour#3628
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
force-pushed
the
remove-ingress-v1beta1-dag
branch
from
1386ef7
to
fe133d6
Compare
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
- Coverage 77.08% 76.85% -0.23%
==========================================
Files 100 100
Lines 7121 7056 -65
==========================================
- Hits 5489 5423 -66
- Misses 1511 1513 +2
+ Partials 121 120 -1
|
…1-dag Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
approved these changes
May 11, 2021
| @@ -3080,777 +3079,575 @@ func TestDAGInsert(t *testing.T) { | |||
| }, | |||
| } | |||
|
|
|||
| i1 := &v1beta1.Ingress{ | |||
| // s3a and b have http/2 protocol annotations | |||
There was a problem hiding this comment.
oof, this file's diff is pretty hard to review, but tests are passing so 🤞
There was a problem hiding this comment.
yeah, i think its maybe best to look at with the split diff type rather than the unified one, should just mostly be removals
stevesloka
approved these changes
May 11, 2021
Contour Project Board
automation
moved this from 1.16 release
to 1.14 release completed
May 11, 2021
youngnick
moved this from 1.14 release completed
to 1.16 release
in Contour Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1beta1 since Ingress v1 does not exist yet in those versions
Updates: #3628