apis/projectcontour: add omitempty JSON tag to caSecret #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caSecret is now optional in downstream validation since skipClientCertValidation can be true. Adds an omitempty JSON tag to omit the field when serializing to JSON and it hasn't been specified. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
sunjayBhatia and
youngnick
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3658 +/- ##
==========================================
+ Coverage 76.80% 77.08% +0.27%
==========================================
Files 100 100
Lines 7158 7121 -37
==========================================
- Hits 5498 5489 -9
+ Misses 1539 1511 -28
Partials 121 121
|
sunjayBhatia
approved these changes
May 10, 2021
youngnick
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caSecret is now optional in downstream validation since
skipClientCertValidation can be true. Adds an omitempty
JSON tag to omit the field when serializing to JSON and
it hasn't been specified.
Signed-off-by: Steve Kriss krisss@vmware.com