Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flyte as adopter #4299

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Conversation

OrlinVasilev
Copy link
Member

Signed-off-by: OrlinVasilev ovasilev@vmware.com

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
@OrlinVasilev OrlinVasilev requested a review from a team as a code owner January 26, 2022 15:32
@OrlinVasilev OrlinVasilev requested review from skriss and sunjayBhatia and removed request for a team January 26, 2022 15:32
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #4299 (0819870) into main (303f316) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0819870 differs from pull request most recent head f1201e2. Consider uploading reports for the commit f1201e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4299      +/-   ##
==========================================
+ Coverage   77.79%   77.81%   +0.01%     
==========================================
  Files         112      112              
  Lines       10026    10026              
==========================================
+ Hits         7800     7802       +2     
+ Misses       2044     2042       -2     
  Partials      182      182              
Impacted Files Coverage Δ
internal/sorter/sorter.go 98.78% <0.00%> (+1.21%) ⬆️

@skriss
Copy link
Member

skriss commented Jan 26, 2022

@OrlinVasilev
Copy link
Member Author

@skriss indeed - waiting on @kumare3 feedback :)

@OrlinVasilev OrlinVasilev self-assigned this Jan 26, 2022
@kumare3
Copy link

kumare3 commented Jan 26, 2022

Approved

@OrlinVasilev
Copy link
Member Author

@kumare3 can you provide some info for the usage please as we discussed in slack , thanks!

@youngnick
Copy link
Member

Awesome, thanks @kumare3! Looking forward to hearing more about the usage!

@kumare3
Copy link

kumare3 commented Jan 27, 2022

So as a usage, Flyte's sandbox environment is powered by Contour and this is the default Ingress we ship with. Sandbox environment has made it possible for data scientists all over to try out Flyte quickly and without contour that would not have been easy.

@OrlinVasilev OrlinVasilev added the area/community Community Issues and discussions label Jan 27, 2022
Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
@OrlinVasilev
Copy link
Member Author

@skriss @kumare3 @youngnick added the text and fixed formatting!

@OrlinVasilev OrlinVasilev merged commit 099c100 into projectcontour:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/community Community Issues and discussions release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants