Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #5380

Merged
merged 1 commit into from
May 19, 2023
Merged

Update README.md #5380

merged 1 commit into from
May 19, 2023

Conversation

SimonVerhoeven
Copy link
Contributor

@SimonVerhoeven SimonVerhoeven commented May 19, 2023 •
edited
Loading

Corrected documentation

@SimonVerhoeven SimonVerhoeven requested a review from a team as a code owner May 19, 2023 15:13
@SimonVerhoeven SimonVerhoeven requested review from tsaarni and sunjayBhatia and removed request for a team May 19, 2023 15:13
@github-actions
Copy link

Hi @SimonVerhoeven! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label May 19, 2023
@SimonVerhoeven
Update README.md
f3d3e2e 
Signed-off-by: Simon Verhoeven <verhoeven.simon@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #5380 (f3d3e2e) into main (6efb366) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5380   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         138      138           
  Lines       18269    18269           
=======================================
  Hits        14248    14248           
  Misses       3746     3746           
  Partials      275      275

skriss
skriss approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SimonVerhoeven, LGTM

@skriss skriss merged commit b28dae1 into projectcontour:main May 19, 2023
27 checks passed
@SimonVerhoeven SimonVerhoeven deleted the patch-1 branch May 19, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia sunjayBhatia is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimonVerhoeven @skriss @tsaarni