Adds log-path to the Contour cli
#5813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivation is that I want to use this to redirect the logs of the preStop hook to `/proc/1/fd/1` so it is visible in kubectl logs. Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
davinci26
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
davinci26
added
the
release-note/minor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
==========================================
- Coverage 78.61% 78.50% -0.12%
==========================================
Files 138 138
Lines 19265 19317 +52
==========================================
+ Hits 15146 15164 +18
- Misses 3830 3861 +31
- Partials 289 292 +3
|
tsaarni
reviewed
Oct 13, 2023
Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
|
@projectcontour/maintainers are you interested in the PR above? I am done debugging the issue I was facing, I used this in our fork to test things out and it was a nice QOL improvement for me. I would recommend we put in a path to merge but if you y'all are not interested I will close it |
github-actions
bot
removed
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am debugging a
shutdownissue and getting logs fromshutdownmanager is generally tricky becausepreStopcommand logs don't appear inkubectl logsor generally anywhere unless there is an error.To debug this issue I use this PR in our local PR that adds a
log-pathparameter to contour and redirected the output of the preStop hook to/proc/1/fd/1. See this relevant stackoverflow threadIf I found it useful I believe other people might so I pushed it here as well in case you believe it is generally helpful