Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to 1.21.5 #6053

Merged
merged 2 commits into from Jan 3, 2024
Merged

Conversation

sunjayBhatia
Copy link
Member

No description provided.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added the release-note/small A small change that needs one line of explanation in the release notes. label Jan 3, 2024
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 3, 2024 21:41
@sunjayBhatia sunjayBhatia requested review from tsaarni, stevesloka, a team, davinci26 and clayton-gonsalves and removed request for a team January 3, 2024 21:41
@sunjayBhatia
Copy link
Member Author

debugging macos test races which i cant repro locally with 1.21.5, unlikely that this fixes it but worth a bump

seems like the recent grpc-go bump might be related, see grpc/grpc-go#6485 and grpc/grpc-go#6489 I don't see any failures before bumping to grpc-go 1.60.0

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (054d169) 78.77% compared to head (2457d1c) 78.77%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6053   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files         138      138           
  Lines       19747    19747           
=======================================
  Hits        15555    15555           
  Misses       3888     3888           
  Partials      304      304           

@sunjayBhatia sunjayBhatia merged commit 3dfb0a5 into projectcontour:main Jan 3, 2024
26 checks passed
@sunjayBhatia sunjayBhatia deleted the bump-go-1.21.5 branch January 3, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants