Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: remove gateway controller name config option #6145

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Gateway API: remove gateway controller name config option #6145

merged 7 commits into from
Feb 13, 2024

Conversation

skriss
Copy link
Member

@skriss skriss commented Jan 30, 2024 •
edited

Closes #5923.

@skriss skriss added the do not merge Don't merge this PR until this label is removed. label Jan 30, 2024
@skriss skriss added this to the 1.29.0 milestone Jan 30, 2024
@skriss skriss mentioned this pull request Jan 30, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (bd003fb) 79.46% compared to head (1fd6978) 81.34%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6145      +/-   ##
==========================================
+ Coverage   79.46%   81.34%   +1.87%     
==========================================
  Files         142      134       -8     
  Lines       16254    15778     -476     
==========================================
- Hits        12916    12834      -82     
+ Misses       3024     2650     -374     
+ Partials      314      294      -20
Files Coverage Δ
cmd/contour/servecontext.go 85.40% <100.00%> (-0.04%) ⬇️
internal/k8s/statusaddress.go 82.01% <100.00%> (+2.90%) ⬆️
...provisioner/objects/contourconfig/contourconfig.go 100.00% <100.00%> (ø)
pkg/config/parameters.go 88.03% <100.00%> (+1.33%) ⬆️
cmd/contour/ingressstatus.go 33.80% <0.00%> (ø)
cmd/contour/serve.go 22.53% <3.12%> (+1.51%) ⬆️

@skriss skriss force-pushed the pr-remove-gw-controller-name branch from 9d066b2 to d4c7a12 Compare February 1, 2024 21:18
@skriss skriss force-pushed the pr-remove-gw-controller-name branch from d4c7a12 to a9161ee Compare February 12, 2024 22:14
@skriss skriss added release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. and removed do not merge Don't merge this PR until this label is removed. labels Feb 12, 2024
@skriss
remove controller name
3a22734 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss
doc, example manifest updates
e0c67ab 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss
replace remaining controllers with informers
d068a8f 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss
simplify GWAPI informer creation code
1034601 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss force-pushed the pr-remove-gw-controller-name branch from a9161ee to 1034601 Compare February 13, 2024 14:52
@skriss
changelog
bdbc255 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss changed the title [WIP] remove gateway controller name config option Gateway API: remove gateway controller name config option Feb 13, 2024
@skriss skriss marked this pull request as ready for review February 13, 2024 15:15
@skriss skriss requested a review from a team as a code owner February 13, 2024 15:15
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team February 13, 2024 15:15
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and izturn and removed request for a team February 13, 2024 15:16
sunjayBhatia
sunjayBhatia approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus one question on the CRD annotation

Nice to standardize on just using informers so we don't have multiple ways we reconcile resources

@skriss
make GatewayRef required when Gateway is configured
202ddc7 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss
update E2E
1fd6978 
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss merged commit 1cc89d0 into projectcontour:main Feb 13, 2024
25 of 26 checks passed
@skriss skriss deleted the pr-remove-gw-controller-name branch February 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@davinci26 davinci26 Awaiting requested review from davinci26 davinci26 was automatically assigned from projectcontour/contour-reviewers

@izturn izturn Awaiting requested review from izturn izturn was automatically assigned from projectcontour/contour-reviewers

Assignees
No one assigned
Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes.
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.

drop Contour config file's gateway.controllerName option
2 participants
@skriss @sunjayBhatia