Inform on and use Gateway API v1 types where possible #6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjayBhatia
added
do not merge
|
Based on #6094 as that makes it a little easier to do the find/replace Set as do not merge for now so we wait until after the 1.28.0 release |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6153 +/- ##
==========================================
- Coverage 79.47% 79.46% -0.02%
==========================================
Files 142 142
Lines 16250 16254 +4
==========================================
+ Hits 12915 12916 +1
- Misses 3021 3024 +3
Partials 314 314
|
sunjayBhatia
force-pushed
the
gw-api-import-v1
branch
from
72e1df8
to
8dec4d0
Compare
sunjayBhatia
requested review from
tsaarni and
skriss
and removed request for
a team
sunjayBhatia
removed
the
do not merge
sunjayBhatia
requested review from
a team,
davinci26 and
izturn
and removed request for
a team
Only files that set up an API client scheme or use ReferenceGrant should have the v1beta1 import Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
force-pushed
the
gw-api-import-v1
branch
from
8dec4d0
to
8c84a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only files that set up an API client scheme or use ReferenceGrant should have the v1beta1 import
Fixes: #6150