Changing StatsAddress flag from Int to String to prevent Init container crash loop. #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josebiro
force-pushed
the
master
branch
2 times, most recently
from
f1034ed
to
dd12689
Compare
|
Thanks for this fix. Assigning @alexbrand to review. @josebiro in the future would you please raise a bug so we can track defects across releases. Thanks |
|
This may need a possible backport for 0.6.2 if gimbal users need it, /cc @stevesloka @rosskukulinski |
|
Thanks @josebiro. I think this looks good, but do you mind adding a test case to internal/envoy/config_test.go where we set the stats address and port? |
|
Test added. Checks should pass, everything is signed off, but for some reason github went from passing to waiting. |
josebiro
force-pushed
the
master
branch
2 times, most recently
from
3b04268
to
eca1d06
Compare
|
Rebased; feel free to merge at your will. |
…ults to match reality. Signed-off-by: Joseph Bironas <josebiro@gmail.com> Signed-off-by: Joseph Bironas <josebiro@gmail.com>
Signed-off-by: Joseph Bironas <josebiro@gmail.com>
Signed-off-by: Joseph Bironas <josebiro@gmail.com> Signed-off-by: Joseph Bironas <josebiro@gmail.com>
Signed-off-by: Joseph Bironas <josebiro@gmail.com> Signed-off-by: Joseph Bironas <josebiro@gmail.com>
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fixing deployment defaults for prometheus scraping to match reality.
This is a small bugfix, so didn't file an issue. Let me know if that's not appropriate.
All tests pass. Built and tested via docker and confirmed that: