ingressroute: add a tls.passthrough key to indicate TLS passthrough #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
requested review from
stevesloka and
joshrosso
and removed request for
stevesloka
davecheney
force-pushed
the
ingressroute-tcpproxy-add-passthrough
branch
from
d3ecad8
to
d2dd9a0
Compare
Updates projectcontour#850 TCP proxying requires one of a `tls.secretName` or `tls.passthrough` to be present. The `tls.passthrough` option has no effect if `spec.tcpproxy` is empty. Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney
force-pushed
the
ingressroute-tcpproxy-add-passthrough
branch
from
d2dd9a0
to
e8ef81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #850
TCP proxying requires one of a
tls.secretNameortls.passthroughtobe present. The
tls.passthroughoption has no effect ifspec.tcpproxyis empty.