Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Wrong version extraction for some packages #3

Closed
Glyphack opened this issue Dec 22, 2020 · 0 comments
Closed

Wrong version extraction for some packages #3

Glyphack opened this issue Dec 22, 2020 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Glyphack
Copy link
Contributor

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
I ran linter on contour project And got this:

internal/featuretests/tlsprotocolversion_test.go:20:2: version "auth" not specified in alias "envoy_api_v2_auth" for import path "github/com/envoyproxy/gocontrolplane/envoy/api/v2/auth"
internal/featuretests/tlsprotocolversion_test.go:21:2: version "listener" not specified in alias "envoy_api_v2_listener" for import path "github/com/envoyproxy/gocontrolplane/envoy/api/v2/listener"

What did you expect to happen:
package is couting listener as version, but it's not it should be v2.

@Glyphack Glyphack added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2020
Glyphack added a commit to Glyphack/lint that referenced this issue Dec 31, 2020
Glyphack added a commit to Glyphack/lint that referenced this issue Dec 31, 2020
Updates: projectcontour#3

Signed-off-by: Shayegan Hooshyari <sh.hooshyari@gmail.com>
jpeach pushed a commit that referenced this issue Jan 3, 2021
* Use multichecker instead of unitchecker for -fix option
* Add how to run fix options in readme

Updates: #3
Fixes: #4 

Signed-off-by: Shayegan Hooshyari <sh.hooshyari@gmail.com>
Glyphack added a commit to Glyphack/lint that referenced this issue Apr 24, 2021
Resolves:projectcontour#3

Signed-off-by: Shayegan Hooshyari <sh.hooshyari@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant