Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cqm-models at master instead of a non-existent branch. #1013

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

rbclark
Copy link
Contributor

@rbclark rbclark commented Jul 5, 2018

Builds are currently failing since the the results_object_mongoize no longer exists on cqm-models ever since the changes were merged in projecttacoma/cqm-models#42

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR: (N/A)
  • Internal ticket links to this PR (N/A)
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases (N/A)
  • Tests have been run locally and pass (N/A)

Reviewer 1:

Name: @okeefm

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@rbclark rbclark requested review from okeefm and dczulada July 5, 2018 16:28
Copy link

@okeefm okeefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A needed fix. master seems to be the right branch, as that's what results_object_mongoize was merged into in projecttacoma/cqm-models#42. Looks good to me.

@lmd59
Copy link
Contributor

lmd59 commented Jul 10, 2018

@rbclark Looks like there are some vulnerability problems with the thor gem at this point? Maybe should figure how to update before pulling in?

Name: thor
Version: 0.20.0
Advisory: CVE-2016-10545
Criticality: Unknown
URL: rails/thor#514
Title: Command injection in Thor Gem
Solution: remove or disable this gem until a patch is available!
Vulnerabilities found!

@rbclark
Copy link
Contributor Author

rbclark commented Jul 11, 2018

I just re-ran the bundle-audit job, based on the linked URL the vulnerability isn't actually valid and the decision to create a CVE for it has been reversed.

@rbclark rbclark merged commit 1951a07 into master Jul 12, 2018
@rbclark rbclark deleted the updateCQMModels branch July 12, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants