Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max file size support #20

Merged
merged 7 commits into from
May 30, 2023
Merged

Add max file size support #20

merged 7 commits into from
May 30, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented May 17, 2023

closes

Added

   -ms, -max-size value  max export data size (kb, mb, gb, tb) (default mb)

@RamanaReddy0M RamanaReddy0M changed the title Add max file size support (#12) Add max file size support May 17, 2023
@RamanaReddy0M RamanaReddy0M linked an issue May 17, 2023 that may be closed by this pull request
@RamanaReddy0M RamanaReddy0M marked this pull request as draft May 17, 2023 18:03
fix removing generated temp dir on early exit
@RamanaReddy0M RamanaReddy0M marked this pull request as ready for review May 22, 2023 20:16
@RamanaReddy0M RamanaReddy0M self-assigned this May 22, 2023
@RamanaReddy0M RamanaReddy0M linked an issue May 22, 2023 that may be closed by this pull request
@RamanaReddy0M RamanaReddy0M marked this pull request as draft May 26, 2023 12:18
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts

@RamanaReddy0M RamanaReddy0M marked this pull request as ready for review May 26, 2023 13:11
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • suggesting minor change to avoid invalid domains
  • update flag description in README.md

mutator.go Outdated Show resolved Hide resolved
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human readable input for -ms option, for example

-ms 1gb
-ms 100mb
-ms 1 # will be considered as 1 mb when no unit is provided.

Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to add this as a field type directly in goflags, so that the parsing is transparent (with default to 1Mb as minimal unit) and we can reuse the logic in all tools:

func (flagSet *FlagSet) SizeVarP(...) *FlagData { ... }
func (flagSet *FlagSet) SizeVar(...) *FlagData { ... }

What do you think?

use sizevar
remove deprecated version callback
@ehsandeep ehsandeep requested a review from Mzack9999 May 30, 2023 19:01
@ehsandeep ehsandeep merged commit b6e46a7 into main May 30, 2023
1 check passed
@ehsandeep ehsandeep deleted the issue-12-aterx-max-file-size branch May 30, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs max file size and max runtime flags/switches
4 participants