-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max file size support #20
Conversation
fix removing generated temp dir on early exit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- suggesting minor change to avoid invalid domains
- update flag description in README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
human readable input for -ms
option, for example
-ms 1gb
-ms 100mb
-ms 1 # will be considered as 1 mb when no unit is provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to add this as a field type directly in goflags, so that the parsing is transparent (with default to 1Mb as minimal unit) and we can reuse the logic in all tools:
func (flagSet *FlagSet) SizeVarP(...) *FlagData { ... }
func (flagSet *FlagSet) SizeVar(...) *FlagData { ... }
What do you think?
use sizevar remove deprecated version callback
closes
Added