filter subs starts with hyphen #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunKoyalwar
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
lgtm !
@dogancanbakir , i think this might be happening because of empty payloads
ex: if pattern is {{sub}}-{{word}}.{{suffix}} . if any one of the variables is empty `` then i think this is causing the issue .
this solution works but can you just in case cross check as we can avoid some extra iterations/dedupes if that's the case
|
@tarunKoyalwar, |
ehsandeep
requested changes
Oct 9, 2023
There was a problem hiding this comment.
echo _www.hackerone.com | ./alterx -silent | head -n 10
_www-cloud.hackerone.com
_www2018.hackerone.com
login._www.hackerone.com
dashboard._www.hackerone.com
_www.log.hackerone.com
_www.manager.hackerone.com
wordpress.hackerone.com
_wwwconf.hackerone.com
service-_www.hackerone.com
code-_www.hackerone.com
ehsandeep
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
@dogancanbakir ignore the above comment, it works fine with -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25.