Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic refactor #49

Merged
merged 8 commits into from
Feb 9, 2023
Merged

Logic refactor #49

merged 8 commits into from
Feb 9, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 11, 2023 •
edited

Description

This PR contains the following changes (some breaking-change in functions signature syntax):

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jan 11, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 11, 2023
@Mzack9999 Mzack9999 marked this pull request as draft January 11, 2023 21:06
This was linked to issues Jan 12, 2023
Remove fatal/panic error in internal library #47
Closed
Client.GetData removes valid results if previously retrieved #48
Closed
@Mzack9999 Mzack9999 marked this pull request as ready for review January 12, 2023 18:03
@ehsandeep ehsandeep requested review from tarunKoyalwar and removed request for shashikarsiddharth January 25, 2023 12:40
@Mzack9999 Mzack9999 mentioned this pull request Jan 26, 2023
Merged
tarunKoyalwar
tarunKoyalwar approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment •
edited by Mzack9999

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! Approved with a message

  • Update README.md (since we added new flag -file in this PR)

ehsandeep
ehsandeep requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

./asnmap -d google.com -silent

142.250.0.0/15
2404:6800::/34
2404:6800:4000::/37
2404:6800:4800::/45
2404:6800:4808::/46
2404:6800:480c::/47
2404:6800:480e::/48

IPv6 ranges in CLI output are optional and get included when -v6 is used.

ehsandeep
ehsandeep reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment •
edited by Mzack9999

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mzack9999
Copy link
Member Author

Note: this PR might require a major release version due to breaking changes in the syntax

@ehsandeep ehsandeep merged commit 1aff4d9 into dev Feb 9, 2023
@ehsandeep ehsandeep deleted the issue-48-refactor branch February 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client.GetData removes valid results if previously retrieved Remove fatal/panic error in internal library
3 participants
@Mzack9999 @ehsandeep @tarunKoyalwar