Add Openstack support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunKoyalwar
requested changes
Dec 13, 2022
S0obi
force-pushed
the
feature/support-openstack-provider
branch
from
b5fe8ba
to
95378cb
Compare
Hey @tarunKoyalwar, I rebased on dev and executed go mod tidy |
|
Thanks @S0obi , I will approve this once tests are successful |
S0obi
force-pushed
the
feature/support-openstack-provider
branch
from
95378cb
to
4cce536
Compare
S0obi
force-pushed
the
feature/support-openstack-provider
branch
from
4cce536
to
6384975
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@tarunKoyalwar I justed added missing documentation for |
|
@S0obi , no worries |
ehsandeep
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Openstack API by creating a new
openstackprovider.This first implementation supports username/password authentication with a tenant name. It will display all floating ips defined for all Openstack Instances.
See #258