Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use goflags #40

Merged
merged 5 commits into from
Feb 7, 2022
Merged

use goflags #40

merged 5 commits into from
Feb 7, 2022

Conversation

parrasajad
Copy link
Contributor

@parrasajad parrasajad commented Feb 4, 2022

Description

This PR adds support for goflags

@parrasajad parrasajad linked an issue Feb 4, 2022 that may be closed by this pull request
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about filepath and comparison

internal/runner/options.go Outdated Show resolved Hide resolved
internal/runner/options.go Outdated Show resolved Hide resolved
internal/runner/runner.go Outdated Show resolved Hide resolved
@Mzack9999 Mzack9999 added Type: Enhancement Most issues will probably ask for additions or changes. Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Feb 4, 2022
@ehsandeep ehsandeep linked an issue Feb 4, 2022 that may be closed by this pull request
3 tasks
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • adding mssing cli flag for id filter
   -id string[]            ids to fetch assets from

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Feb 7, 2022
@ehsandeep ehsandeep merged commit 2b0b07e into dev Feb 7, 2022
@ehsandeep ehsandeep deleted the goflags-integration branch February 7, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goflags integration Ability to specify multiple provider/id using flags
3 participants