Adding python Unpack implementation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Enhancement
4 tasks
3 tasks
tarunKoyalwar
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
lgtm !
- we probably need to add documentation for this in README.md
- I think we should also include below notes in docs since this is
unpack i.e C -> golang
https://github.com/Mzack9999/gostruct/blob/30b70932da81da179c2da88daffd06db50d0a25e/struct.go#L3-L17
ehsandeep
previously requested changes
May 1, 2023
ehsandeep
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following DSL functions:
unpackfor one type with endianess (ex>I)xorbetween bytes sequences/strings of same lengthCloses