Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: httpx fallbacks even though -nfs is given for dead hosts #1159

Merged
merged 1 commit into from
May 9, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented May 8, 2023

@RamanaReddy0M RamanaReddy0M self-assigned this May 8, 2023
@RamanaReddy0M RamanaReddy0M linked an issue May 8, 2023 that may be closed by this pull request
@tarunKoyalwar tarunKoyalwar changed the title fix converting https to httpx scheme with ports switch fix: httpx fallbacks even though -nfs is given for dead hosts May 8, 2023
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Before

$  echo https://123.google.com/ | httpx -duc -probe -sc -debug -nfs -ports 443

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

		projectdiscovery.io

[INF] Dumped HTTP request for https://123.google.com:443

GET / HTTP/1.1
Host: 123.google.com
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Accept-Charset: utf-8
Accept-Encoding: gzip

[INF] Dumped HTTP request for http://123.google.com:443

GET / HTTP/1.1
Host: 123.google.com:443
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2227.1 Safari/537.36
Accept-Charset: utf-8
Accept-Encoding: gzip

[DBG] Failed 'http://123.google.com:443': GET http://123.google.com:443 giving up after 1 attempts: Get "http://123.google.com:443": no port found for host
http://123.google.com:443 [FAILED]

After

$  echo https://123.google.com/ | ./httpx -duc -probe -sc -debug -nfs -ports 443

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

		projectdiscovery.io

[INF] Dumped HTTP request for https://123.google.com:443

GET / HTTP/1.1
Host: 123.google.com
User-Agent: msnbot/1.1 ( http://search.msn.com/msnbot.htm)
Accept-Charset: utf-8
Accept-Encoding: gzip

[DBG] Failed 'https://123.google.com:443': GET https://123.google.com:443 giving up after 1 attempts: Get "https://123.google.com:443": no port found for host
https://123.google.com [FAILED]

@tarunKoyalwar tarunKoyalwar linked an issue May 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong output message if used port switch if host not exist, nfs is ignored if we use port switch
3 participants