Don't write missing screenshots to index file #1193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screenshots in index_screenshot.txt do not correspond with the files in the screenshot directory. The error causing this issue is that
ScreenshotWithBody
returnscontext deadline exceeded
for the following URLs:And we are initializing the
screenshotPath
regardless of whether there is an error and returning it. Thus, we write it to theindex_screenshot.txt
file. There are two issues, actually:ScreenshotWithBody
- the root cause.To repro the issue(from #1125):
I was able to fix the first issue by avoiding the initialization of
screenshotPath
beforehand. I'll further investigate the root cause.