Redirect policy with hsts #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the location would go from HTTPs to HTTP it would follow to HTTPs if an HTSTS header is present
…even if the location would go from HTTPs to HTTP it would follow to HTTPs if an HTSTS header is present" This reverts commit c4810ff.
…ies the URL accordingly if necessary
ehsandeep
added
the
Status: Review Needed
Mzack9999
approved these changes
Sep 11, 2023
ehsandeep
removed
the
Status: Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a redirect policy which respects Strict-Transport-Security header (in a basic version, if a header is present without checking the content).
If during a redirect a HSTS header is added but the URL scheme is HTTP, the HTTP URL would be requested (maybe net/http/client would be a better place for this), which could either lead to timeouts (if the HTTP service is not available) or at least would behave differently than browser implementations.
The redirect policy can be switched on via the options (--respect-hsts / -rhsts).