Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrome unsafe port err by setting explicitly-allowed-ports #1343

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fix chrome unsafe port err by setting explicitly-allowed-ports #1343

merged 3 commits into from
Nov 28, 2023

Conversation

seeyarh
Copy link
Contributor

@seeyarh seeyarh commented Sep 1, 2023 •
edited
Loading

Closes #1342

@ehsandeep ehsandeep linked an issue Sep 1, 2023 that may be closed by this pull request
httpx unable to screenshot webservers on port 7 #1342
Closed
@dogancanbakir
Copy link
Member

I suggest adding "-ho" to start headless chrome with additional options for greater flexibility.

   -ho, -headless-options string[]   start headless chrome with additional options

See:
https://github.com/projectdiscovery/katana#-headless-options
https://github.com/projectdiscovery/katana/blob/78fbb62216645404c0ecf2380741e0eb2dee3e46/pkg/engine/hybrid/hybrid.go#L170

@ehsandeep ehsandeep added the Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. label Sep 7, 2023
dogancanbakir
dogancanbakir approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsandeep ehsandeep merged commit 91139db into projectdiscovery:dev Nov 28, 2023
11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 16, 2024
Merged
@ppb007 ppb007 mentioned this pull request Jan 16, 2024
Closed
@ppb007 ppb007 mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@dogancanbakir dogancanbakir dogancanbakir approved these changes

Assignees
No one assigned
Labels
Status: Revision Needed Submitter of PR needs to revise the PR related to the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpx unable to screenshot webservers on port 7
4 participants
@seeyarh @dogancanbakir @ehsandeep @Mzack9999