Reworking favicon hash calculation #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
Type: Enhancement
This was
linked to
issues
Dec 18, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ehsandeep
requested changes
Dec 27, 2022
There was a problem hiding this comment.
- path handling fix to request favicon resource
echo https://api.hackerone.com | ./httpx -favicon -v
__ __ __ _ __
/ /_ / /_/ /_____ | |/ /
/ __ \/ __/ __/ __ \| /
/ / / / /_/ /_/ /_/ / |
/_/ /_/\__/\__/ .___/_/|_|
/_/ v1.2.5
projectdiscovery.io
Use with caution. You are responsible for your actions.
Developers assume no liability and are not responsible for any misuse or damage.
[WRN] could not calculate favicon hash: could not fetch favicon: Get "assets/images/favicon.ico": unsupported protocol scheme ""
https://api.hackerone.com- disabling automatic redirect for favicon option
ehsandeep
requested changes
Jan 6, 2023
There was a problem hiding this comment.
@Mzack9999 since the favicon path may have more possible paths than /favicon.ico, it would be nice to write the path information in the json output for identification.
When the favicon is identified, favicon_path can be included in json output.
echo https://api.hackerone.com | ./httpx -favicon -json | jq . "favicon": "595148549",
+ "favicon_path": "/assets/images/favicon.ico",
|
SonarCloud Quality Gate failed. |
ehsandeep
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
echo https://api.hackerone.com | ./httpx -favicon -json -silent | jq .{
"timestamp": "2023-01-06T18:23:29.749197+05:30",
"csp": {
"domains": [
"cdn.jsdelivr.net",
"*.algolia.net",
"*.algolianet.com",
"www.google-analytics.com\n",
"www.google-analytics.com"
]
},
"hash": {
"body_md5": "65782d606fe962c372dd0515e25282c9",
"body_mmh3": "-1965878003",
"body_sha256": "c23f6854459a5c324efe5007d30a753a566c9639539e6fc72b5eb62157ada729",
"body_simhash": "9815579009636610750",
"header_md5": "f49442f489e10e4db61119b22869bafa",
"header_mmh3": "556908435",
"header_sha256": "6967ce655312798fe467bfe4a1634044e829aec12bbd18c75aba0f45d660d737",
"header_simhash": "15597847997707957536"
},
"port": "443",
"url": "https://api.hackerone.com:443",
"input": "https://api.hackerone.com",
"title": "HackerOne API",
"scheme": "https",
"webserver": "cloudflare",
"content_type": "text/html",
"method": "GET",
"host": "104.16.99.52",
"path": "/",
"favicon": "595148549",
"favicon_path": "/assets/images/favicon.ico",
"time": "606.735167ms",
"a": [
"104.16.99.52",
"104.16.100.52",
"2606:4700::6810:6434",
"2606:4700::6810:6334"
],
"words": 1642,
"lines": 360,
"status_code": 200,
"content_length": 8486,
"failed": false
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactor #842 and simplifies it to perform at most one additional request for favicon calculation.