Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving py smb to runtime #676

Merged
merged 2 commits into from Oct 5, 2023
Merged

Moving py smb to runtime #676

merged 2 commits into from Oct 5, 2023

Conversation

Mzack9999
Copy link
Member

This PR creates smb python server file at runtime in /tmp

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 2, 2023
@Mzack9999 Mzack9999 self-assigned this Oct 2, 2023
This was linked to issues Oct 2, 2023
SMB listener not working on 1.1.5 (but Fixed it as well) #646
Closed
windows The TCP SMB service has unexpectedly stopped #643
Closed
dogancanbakir
dogancanbakir approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left comments for minor changes

pkg/server/smb_server.go Show resolved Hide resolved
pkg/server/smb_server.go Outdated Show resolved Hide resolved
@Mzack9999 Mzack9999 merged commit 5bfec57 into dev Oct 5, 2023
8 checks passed
@Mzack9999 Mzack9999 deleted the bugfix-646-py-smb branch October 5, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
2 participants
@Mzack9999 @dogancanbakir