Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to reflect result struct change #397

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

ShubhamRasal
Copy link
Contributor

closes #388

@ShubhamRasal ShubhamRasal self-assigned this Apr 3, 2023
@ShubhamRasal ShubhamRasal mentioned this pull request Apr 3, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@ehsandeep ehsandeep linked an issue Apr 4, 2023 that may be closed by this pull request
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the code from readme to the example folder, similar to other projects and make it part of build test to detect breaking changes.

@ehsandeep ehsandeep merged commit b47ab66 into dev Apr 8, 2023
10 checks passed
@ehsandeep ehsandeep deleted the issue-388-update-lib-eg branch April 8, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something wrong with the demo of 'Katana as a library' in readme
2 participants