Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant c.browser.Connect() #428

Merged
merged 7 commits into from
May 9, 2023
Merged

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented May 3, 2023

#377 panic: Browser.Client and Browser.ControlURL can't be set at the same time

browser.client already initialised at https://github.com/projectdiscovery/katana/pull/428/files#diff-bb6d36c898cef9ab8fc51c0e7c843b608bdb1c68ceee5101752f0cc647476685R96

@RamanaReddy0M RamanaReddy0M self-assigned this May 3, 2023
@RamanaReddy0M
Copy link
Contributor Author

./katana -u https://test.team -hl -noi -scp /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome -cdd ~/temp


   __        __                
  / /_____ _/ /____ ____  ___ _
 /  '_/ _  / __/ _  / _ \/ _  /
/_/\_\\_,_/\__/\_,_/_//_/\_,_/                                                   

                projectdiscovery.io

[INF] Current katana version v1.0.2-dev (development)
[INF] Started headless crawling for => https://test.team
https://www.test.team/js/jquery.fittext.js
https://www.test.team/css/page_specific/landing_themes/loading_spinner.css
https://www.test.team/css/page_specific/landing_themes/samir/style.css
https://www.test.team/odf/js/odf.js
https://www.test.team/
https://test.team
https://www.test.team/odf/js/%27%20+%20Odf.get%28%27loading_image%27%29%20+%20%27
https://www.test.team/odf/js/%27%20+%20Odf.get%28%27loading_image_black_bg_big%27%29%20+%20%27

Copy link
Contributor

@ShubhamRasal ShubhamRasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShubhamRasal ShubhamRasal self-requested a review May 3, 2023 08:26
@ShubhamRasal
Copy link
Contributor

image

@ehsandeep ehsandeep merged commit 7275aa4 into dev May 9, 2023
13 checks passed
@ehsandeep ehsandeep deleted the issue-377-browser-panic branch May 9, 2023 08:56
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: Browser.Client and Browser.ControlURL can't be set at the same time
4 participants