Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom header from file #436

Merged
merged 6 commits into from
May 16, 2023
Merged

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented May 10, 2023

#435 Custom header option to support file input

@RamanaReddy0M RamanaReddy0M self-assigned this May 10, 2023
@RamanaReddy0M RamanaReddy0M linked an issue May 10, 2023 that may be closed by this pull request
@RamanaReddy0M RamanaReddy0M requested review from ShubhamRasal and tarunKoyalwar and removed request for ShubhamRasal May 10, 2023 08:59
@tarunKoyalwar
Copy link
Member

$ ./katana -H cookie.txt -u https://mail.google.com -headless -proxy http://127.0.0.1:8080

   __        __                
  / /_____ _/ /____ ____  ___ _
 /  '_/ _  / __/ _  / _ \/ _  /
/_/\_\\_,_/\__/\_,_/_//_/\_,_/							 

		projectdiscovery.io

[INF] Current katana version v1.0.2-dev (development)
[INF] Started headless crawling for => https://mail.google.com
https://accounts.google.com/v3/signin/
https://mail.google.com
https://accounts.google.com/TOS?loc=IN&hl=en-US
https://www.google.com
https://support.google.com/chrome/answer/6130773?hl=en-US
https://accounts.google.com/TOS?loc=IN&hl=en-US&privacy=true
https://support.google.com/accounts?hl=en-US&p=account_iph
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x80 pc=0x105704d20]

goroutine 435 [running]:
github.com/projectdiscovery/katana/pkg/engine/hybrid.(*Crawler).navigateRequest(0x14001f5d260, 0x1400126e050, 0x140013b1360)
	/Users/tarun/Codebase/katana/pkg/engine/hybrid/crawl.go:160 +0xa10
github.com/projectdiscovery/katana/pkg/engine/common.(*Shared).Do.func1()
	/Users/tarun/Codebase/katana/pkg/engine/common/base.go:226 +0xbc
created by github.com/projectdiscovery/katana/pkg/engine/common.(*Shared).Do
	/Users/tarun/Codebase/katana/pkg/engine/common/base.go:216 +0x248

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm!

I found a panic while trying this out . I think we can resolve that in this PR

pkg/engine/hybrid/crawl.go Outdated Show resolved Hide resolved
@tarunKoyalwar
Copy link
Member

Note

@tarunKoyalwar
Copy link
Member

@RamanaReddy0M , headless mode issue should be resolved with #437

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mzack9999 Mzack9999 merged commit 5506d47 into dev May 16, 2023
13 checks passed
@Mzack9999 Mzack9999 deleted the issue-435-custom-headers-option branch May 16, 2023 17:27
@ehsandeep ehsandeep added the Type: Enhancement Most issues will probably ask for additions or changes. label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
4 participants