Add timeout to scan through SOCKS proxy #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when scanning through a SOCKS proxy, only the timeout between the scanner and proxy is configurable, whereas the remote connection between proxy and target is not. This is undesirable as scans can take a long time if the remote connection takes a long time.
This change adds a context to the proxyDialer, which sets this timeout for the connection as per the main configuration option.
Alternative:
We could potentially expose this timeout as a separate CLI argument, but it was not needed for my use case.