Exclude waf #749
Merged
Exclude waf #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naabu v2.1.2
naabu v2.1.3
version update
Bugfix update
naabu v2.1.6
tarunKoyalwar
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
lgtm !
$ cdncheck -i 45.60.124.29
__ __ __
_________/ /___ _____/ /_ ___ _____/ /__
/ ___/ __ / __ \/ ___/ __ \/ _ \/ ___/ //_/
/ /__/ /_/ / / / / /__/ / / / __/ /__/ ,<
\___/\__,_/_/ /_/\___/_/ /_/\___/\___/_/|_|
projectdiscovery.io
[INF] Current cdncheck version v1.0.9 (latest)
45.60.124.29
[INF] Found result: 1 (WAF: 1)Before
$ sudo naabu -host 45.60.124.29 -ec
Password:
__
___ ___ ___ _/ / __ __
/ _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/
projectdiscovery.io
[INF] Current naabu version 2.1.6 (latest)
[INF] Running host discovery scan
[INF] Running SYN scan with root privileges
[INF] Found 50 ports on host 45.60.124.29 (45.60.124.29)
45.60.124.29:2000
45.60.124.29:10000
45.60.124.29:6000
45.60.124.29:554
45.60.124.29:631
45.60.124.29:8000
45.60.124.29:21
45.60.124.29:7070
45.60.124.29:5900
45.60.124.29:1720
...Now
$ sudo ./naabu -host 45.60.124.29 -ec
__
___ ___ ___ _/ / __ __
/ _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/
projectdiscovery.io
[INF] Current naabu version 2.1.6 (latest)
[INF] Running host discovery scan
[INF] Running SYN scan with root privileges
[INF] Found 2 ports on host 45.60.124.29 (45.60.124.29)
45.60.124.29:80
45.60.124.29:443
thanks for the PR @JoshuaMart and sorry for the delay in reviewing PR
ehsandeep
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is associated to #745.
As it stands, Naabu does not exclude WAF scanning, which can return false positives as explained in the issue.
Rather than adding a new flag such as
--exclude-waf, I've modified the current CDN verification function. Adding a new flag seems a bit counter-intuitive to me, as I can't see in which case you'd want to exclude CDN scanning but not WAF, or vice versa.Perhaps the function names / some comments are no longer explicit enough with the proposed modification.
Let me know what you think