Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-time support for exsiting webhooks #43

Closed
ehsandeep opened this issue Jun 5, 2021 · 1 comment · Fixed by #59 or #71
Closed

Multi-time support for exsiting webhooks #43

ehsandeep opened this issue Jun 5, 2021 · 1 comment · Fixed by #59 or #71
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@ehsandeep
Copy link
Member

ehsandeep commented Jun 5, 2021

Currently, notify doesn't support reusing the same webhook multiple time with different keys/tokens.

For example, if we have the following entry in the config file:-

discord_webhook_url: https://discord.com/api/webhooks/7730624177430/XXXX
discord_username: A
discord: true

discord_webhook_url: https://discord.com/api/webhooks/77306241774308/YYYY
discord_username: B
discord: true

Notify will only post to 2nd discord_webhook_url and the same goes for any other webhook, slack, telegram.

With this support -

For the cases when we want to post the same results on multiple servers/channels, we can simply define the webhook multiple times in config with different values to achieve this.

@ehsandeep ehsandeep added the Type: Enhancement Most issues will probably ask for additions or changes. label Jun 5, 2021
@ehsandeep
Copy link
Member Author

Related issue - #40

@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jul 24, 2021
@ehsandeep ehsandeep linked a pull request Jul 24, 2021 that will close this issue
@ehsandeep ehsandeep linked a pull request Aug 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
1 participant