replace underscore with escaped underscore #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ehsandeep review please |
ehsandeep
added
the
Type: Bug
ehsandeep
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
Hey @bugrakocabay, just wanted to say thanks for fixing that bug! Sorry it took me a while to review it. Appreciate your help!
|
asterisk also should be escaped otherwise it gets an error. echo "*.eg.com"|notify Bad Request: can't parse entities: Can't find end of the entity starting at byte offset 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in this issue #239, when sending a message that has a "_" character in telegram gives an error. This is actually caused by parsing the message as markdown.
Issue has been solved by replacing all occurrences of underscore in string with escaped underscore.