Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong part name #6482

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Conversation

emrekara369
Copy link
Contributor

@emrekara369 emrekara369 commented Jan 6, 2023

Part name should be "header" instead "location"

Template Validation

I've validated this template locally?

  • YES
  • NO

Part name should be "header" instead "location"
@ehsandeep
Copy link
Member

@emrekara369 this is not an error. Actually, nuclei do also support using any header key name as part value, so in this case, I've used location to look for a redirect string within Location header only, so the matcher is more specific instead of looking in all the headers.

let me know if it makes sense or if you experienced any issues.

@emrekara369
Copy link
Contributor Author

@emrekara369 this is not an error. Actually, nuclei do also support using any header key name as part value, so in this case, I've used location to look for a redirect string within Location header only, so the matcher is more specific instead of looking in all the headers.

let me know if it makes sense or if you experienced any issues.

So, can you take a look at this example?

First of all, I start a scan for this example, which I know is an Open Redirect Vulnerability of the template in its original form.

Original template:
image

Scan results with original template:
image

I can manually verify that "https://example.com" is triggering the Open Redirect Vulnerability with the "//%5cevil.com" payload
I change the value of "part" to "header" and run the same scan again for the same target.

Edited template:
image

Scan results with edited template:
image

@ehsandeep
Copy link
Member

thank you for the update and fix @emrekara369, I will see what's wrong with location part and open new issue in nuclei engine if needed.

@ehsandeep ehsandeep merged commit 09504ab into projectdiscovery:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants