Reduce false-positives in Open Redirect regexes #6815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template / PR Information
I noticed a large number of false positives in a large-scale scan I did with the nuclei templates. This was primarily due to most regexes counting a
Location
header like the following as an open redirect:Location: interact.sh
But this actually redirects to the relative path
/interact.sh
instead of being an open redirect. In the original regex, the protocol prefix was optional, but it should actually be required.The change is simply as follows (regex101):
In the commits, I made the change to all regexes that used the optional protocol because they are all incorrect. See the files changed for all templates that are affected.
Template Validation
I've validated this template locally?