Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 7265 #7266

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix issue 7265 #7266

merged 1 commit into from
May 23, 2023

Conversation

jub0bs
Copy link
Contributor

@jub0bs jub0bs commented May 20, 2023

Template / PR Information

Fixes #7265.

Template Validation

I've validated this template locally?

  • YES
  • NO

@princechaddha
Copy link
Member

Hello @jub0bs, thank you so much for updating this template and contributing to the project 🍻

I agree that removing these headers would eliminate unnecessary noise. Additionally, we have dedicated templates specifically to test for CORS misconfigurations. Thanks

@princechaddha princechaddha merged commit 0b3b164 into projectdiscovery:main May 23, 2023
2 checks passed
@princechaddha princechaddha added the Done Ready to merge label May 23, 2023
@jub0bs jub0bs deleted the fix-issue-7265-drop-cors-checks-from-missing-security-headers-tmpl branch May 23, 2023 13:41
@jub0bs
Copy link
Contributor Author

jub0bs commented May 23, 2023

@princechaddha Keep up the great work. I'm only starting to write my own templates, but the Nuclei engine is excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-missing-security-headers: checking for the absence of CORS headers is useless
3 participants