Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: templates with generic tag should not depend on specific tech #8009

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

adrlsx
Copy link
Contributor

@adrlsx adrlsx commented Aug 18, 2023

Generic tag harmonization

Some templates were wrongfully tag generic.
This small PR removes the generic tag from templates depending on a specific technology like AWS or Akamai.
In the same logic, no CVE should be marked as generic.

Generic tags were also added to certain templates, for example those in http/exposures/tokens/generic/.

Reproducibility

nuclei -tags generic -tl

Template Validation

I've validated this template locally?

  • YES
  • NO
nuclei_template_validation

@DhiyaneshGeek DhiyaneshGeek self-assigned this Aug 18, 2023
@DhiyaneshGeek DhiyaneshGeek added the Done Ready to merge label Aug 18, 2023
@DhiyaneshGeek DhiyaneshGeek added the good first issue Good for newcomers label Aug 18, 2023
@pussycat0x
Copy link
Contributor

Hi @adrlsx Thank you for your contribution to this project. Your efforts are greatly appreciated. Cheers!

@pussycat0x pussycat0x merged commit e6bf205 into projectdiscovery:main Aug 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Ready to merge good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants