Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frp-default-login: more precise body match #8058

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Aug 22, 2023

Template / PR Information

This PR tightens the word matcher for the frp-default-login template to reduce false positives.

The /api/proxy/tcp endpoint in frps returns JSON:

curl http://admin:admin@localhost:7500/api/proxy/tcp
{"proxies":[]}⏎                               

This PR was motivated by a false positive we saw in the wild with a host that returned 200 for any URL, and happened to mention "proxies" in the body.

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

Before PR (localhost is a real frps endpoint):

[VER] [frp-default-login] Sent HTTP request to http://localhost:7500/api/proxy/tcp
[frp-default-login] [http] [high] http://localhost:7500/api/proxy/tcp [password="admin",username="admin"]
[VER] [frp-default-login] Sent HTTP request to https:///false-positive.a.run.app/api/proxy/tcp
[frp-default-login] [http] [high] https://false-positive.a.run.app/api/proxy/tcp [username="admin",password="admin"]

After PR:

[VER] [frp-default-login] Sent HTTP request to http://localhost:7500/api/proxy/tcp
[frp-default-login] [http] [high] http://localhost:7500/api/proxy/tcp [password="admin",username="admin"]
[VER] [frp-default-login] Sent HTTP request to https:///false-positive.a.run.app/api/proxy/tcp

Additional References:

@princechaddha princechaddha self-assigned this Aug 22, 2023
@princechaddha princechaddha added the Done Ready to merge label Aug 22, 2023
@princechaddha
Copy link
Member

Hello @tstromberg, thank you so much for sharing this template with the community and contributing to this project 🍻

You can join our discord server. It's a great place to connect with fellow contributors and stay updated with the latest developments. Thank you once again

@princechaddha princechaddha merged commit 761fb91 into projectdiscovery:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants