Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dns-rebinding.yaml - fix regex 10. #9049

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

hazaldrv
Copy link
Contributor

DNS regex fix

The regex code was incorrectly treating domains starting with 10 or 21 as internal IP addresses, causing the template to malfunction. After the modification in the regex code, this issue has been resolved.

@olearycrew
Copy link
Contributor

@hazaldrv thanks for this contribution, but this regex is correct as:

@olearycrew olearycrew closed this Jan 30, 2024
@hazaldrv
Copy link
Contributor Author

@olearycrew thanks to feedback, but not correctly understood.

The regex code fails to extract the IP address correctly and obtains an incorrect IP address. For example;

If the IP address is 110.45.154.91, due to an error in the regex code, it perceives the IP address as 10.45.154.91, stating the potential for a "dns-rebinding" attack based on this misinterpretation.

@olearycrew olearycrew reopened this Jan 31, 2024
@olearycrew
Copy link
Contributor

Ah thanks for the update @hazaldrv that makes sense!!

I reopened this.

@DhiyaneshGeek DhiyaneshGeek self-assigned this Feb 1, 2024
@DhiyaneshGeek DhiyaneshGeek added the Done Ready to merge label Feb 1, 2024
@DhiyaneshGeek DhiyaneshGeek merged commit ceb9556 into projectdiscovery:main Feb 2, 2024
2 checks passed
@DhiyaneshGeek DhiyaneshGeek added the good first issue Good for newcomers label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Ready to merge good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants