Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional field update for DNS template #1244

Closed
ehsandeep opened this issue Nov 11, 2021 · 0 comments · Fixed by #1284
Closed

Optional field update for DNS template #1244

ehsandeep opened this issue Nov 11, 2021 · 0 comments · Fixed by #1284
Assignees
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@ehsandeep
Copy link
Member

Please describe your feature request:

Currently, DNS block contains name,type,class,recursion,retries as mandatory fields to include in the template, where
only the type is subject to change most of times, as such we can make last three fields optional with use of sane default values.

Current default:-

dns:
  - name: "{{FQDN}}"
    type: NS
    class: inet
    recursion: true
    retries: 3

After update default:

dns:
  - name: "{{FQDN}}"
    type: NS
@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix labels Nov 11, 2021
@Ice3man543 Ice3man543 linked a pull request Nov 23, 2021 that will close this issue
4 tasks
@Ice3man543 Ice3man543 self-assigned this Nov 23, 2021
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 23, 2021
@ehsandeep ehsandeep added Status: In Progress This issue is being worked on, and has someone assigned. Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 30, 2021
@ehsandeep ehsandeep added this to the v2.5.4 milestone Dec 3, 2021
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants