Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default fields for DNS requests #1284

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Added default fields for DNS requests #1284

merged 4 commits into from
Dec 3, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Nov 23, 2021

Proposed changes

Checklist

Closes #1205

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 linked an issue Nov 23, 2021 that may be closed by this pull request
@Ice3man543 Ice3man543 self-assigned this Nov 23, 2021
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 23, 2021
@Ice3man543 Ice3man543 linked an issue Nov 23, 2021 that may be closed by this pull request
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo docs.hackerone.com | ./nuclei -t a.yaml 

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   2.5.4-dev

		projectdiscovery.io

[WRN] Use with caution. You are responsible for your actions.
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104dae86c]

goroutine 1 [running]:
github.com/projectdiscovery/nuclei/v2/pkg/protocols/dns.(*Request).Compile(0x140000148c0, 0x140004868c0)
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/dns/dns.go:106 +0x3c
github.com/projectdiscovery/nuclei/v2/pkg/protocols/common/executer.(*Executer).Compile(0x1400043dc60)
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/common/executer/executer.go:28 +0x80
github.com/projectdiscovery/nuclei/v2/pkg/templates.Parse({0x14000378440, 0x31}, {0x0, 0x0}, {{0x0, 0x0}, {0x0, 0x0}, {{0x0, 0x0}, ...}, ...})
	/Users/geekboy/Github/nuclei/v2/pkg/templates/compile.go:92 +0x4e0
github.com/projectdiscovery/nuclei/v2/pkg/catalog/loader.(*Store).LoadTemplates(0x140001523f0, {0x140000706d0, 0x1, 0x1})
	/Users/geekboy/Github/nuclei/v2/pkg/catalog/loader/loader.go:215 +0x34c
github.com/projectdiscovery/nuclei/v2/pkg/catalog/loader.(*Store).Load(0x140001523f0)
	/Users/geekboy/Github/nuclei/v2/pkg/catalog/loader/loader.go:137 +0x40
github.com/projectdiscovery/nuclei/v2/internal/runner.(*Runner).RunEnumeration(0x14000152090)
	/Users/geekboy/Github/nuclei/v2/internal/runner/runner.go:272 +0x83c
main.main()
	/Users/geekboy/Github/nuclei/v2/cmd/nuclei/main.go:33 +0x18c
id: test

info:
  name: test
  author: pdteam
  severity: info

dns:
  - name: "{{FQDN}}"
    type: A

    extractors:
      - type: regex
        group: 1
        regex:
          - "IN\tCNAME\t(.+)"

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 30, 2021
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Dec 2, 2021
@ehsandeep ehsandeep merged commit eac6ea1 into dev Dec 3, 2021
@ehsandeep ehsandeep deleted the dns-optional branch December 3, 2021 03:44
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional field update for DNS template
3 participants