Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip Symbol-Table/Debug/Path Info on release #1353

Closed
Mzack9999 opened this issue Dec 9, 2021 · 0 comments · Fixed by #1356 or #1368
Closed

Strip Symbol-Table/Debug/Path Info on release #1353

Mzack9999 opened this issue Dec 9, 2021 · 0 comments · Fixed by #1356 or #1368
Assignees
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@Mzack9999
Copy link
Member

Nuclei version:

master: 2.5.4
dev: 2.5.5-dev

Current Behavior:

Binary release contains symbol table and debugging information

Expected Behavior:

  • Strip symbol table during build process
  • Strip path information

Steps To Fix:

  1. Strip symbol + debug info with -ldflags="-s -w"
  2. Strip path info with -trimpath (https://go.dev/doc/go1.13#go-command)
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 9, 2021
@ehsandeep ehsandeep added the Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix label Dec 9, 2021
@Mzack9999 Mzack9999 linked a pull request Dec 10, 2021 that will close this issue
4 tasks
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Dec 10, 2021
@Mzack9999 Mzack9999 self-assigned this Dec 10, 2021
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 10, 2021
@ehsandeep ehsandeep linked a pull request Dec 13, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
2 participants