Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests for replacer.go #2460

Closed
2 tasks done
forgedhallpass opened this issue Aug 19, 2022 · 2 comments · Fixed by #2691
Closed
2 tasks done

Create unit tests for replacer.go #2460

forgedhallpass opened this issue Aug 19, 2022 · 2 comments · Fixed by #2691
Labels
good first issue Good for newcomers Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
nuclei v2.8.0

Comments

@forgedhallpass
Copy link
Contributor

forgedhallpass commented Aug 19, 2022 •
edited by Mzack9999

Create unit tests for the following methods:

  • Replace
  • ReplaceOne

The tests should contain both positive and negative scenarios.
@forgedhallpass forgedhallpass added Type: Enhancement Most issues will probably ask for additions or changes. good first issue Good for newcomers labels Aug 19, 2022
@RyanTalbot
Copy link

Happy to make a start on this sometime this week.

@forgedhallpass
Copy link
Contributor Author

Happy to make a start on this sometime this week.

Great, I've assigned it to you. Happy coding @RyanTalbot

This was referenced Oct 8, 2022
Closed
Merged
@ehsandeep ehsandeep linked a pull request Oct 9, 2022 that will close this issue
Issue 2460: extended unit tests for replacer #2691
Merged
4 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Oct 10, 2022
@ehsandeep ehsandeep added this to the v2.8.0 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
nuclei v2.8.0
Development

Successfully merging a pull request may close this issue.

Issue 2460: extended unit tests for replacer bertold/nuclei
3 participants
@RyanTalbot @ehsandeep @forgedhallpass