Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2460: extended unit tests for replacer #2691

Merged
merged 1 commit into from Oct 10, 2022
Merged

Issue 2460: extended unit tests for replacer #2691

merged 1 commit into from Oct 10, 2022

Conversation

bertold
Copy link
Contributor

@bertold bertold commented Oct 8, 2022

Proposed changes

  • extended unit tests for Replace method
  • added unit tests for ReplaceOne method

The tests are implemented as table-driven tests for readability, extensibility. This closes Issue #2460.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep linked an issue Oct 9, 2022 that may be closed by this pull request
Create unit tests for replacer.go #2460
Closed
2 tasks
@ehsandeep ehsandeep merged commit 1af96fc into projectdiscovery:dev Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create unit tests for replacer.go
3 participants
@bertold @ehsandeep @Mzack9999