-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves project-discovery/nuclei#822 - Add severity label to GitHub reporter #1036
Conversation
Hello @revblock, Thank you, and congrats for your first contribution! Even though the issue title only mentions GitHub, I believe for the sake of completeness and uniformity we could also do it for the GitLab and Jira integrations as well. @ehsandeep @Ice3man543 what do you think? |
@forgedhallpass I'm happy to do that, I can take a look this weekend and get it sorted 👍 |
The only thing that we need to test out whether creating new labels are permitted through all the APIs or not. |
@forgedhallpass I've added the label to the GitLab and Jira reporters. I've tested this against the cloud versions of both of these. Unfortunately, I don't have access to the on-prem versions to test against but as far as I'm aware the functionality is the same in both. One thing I did notice testing this was the example Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Add a Severity label when creating a GitHub issue.
This is my first time contributing to this project. I wasn't sure if the string format should be in the formatting package or if it's fine in the function itself. Happy to make any changes though.
Thanks,