Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves project-discovery/nuclei#822 - Add severity label to GitHub reporter #1036

Merged
merged 4 commits into from
Sep 26, 2021

Conversation

revblock
Copy link
Contributor

Add a Severity label when creating a GitHub issue.

This is my first time contributing to this project. I wasn't sure if the string format should be in the formatting package or if it's fine in the function itself. Happy to make any changes though.

Thanks,

@forgedhallpass
Copy link
Contributor

forgedhallpass commented Sep 17, 2021

Hello @revblock,

Thank you, and congrats for your first contribution!

Even though the issue title only mentions GitHub, I believe for the sake of completeness and uniformity we could also do it for the GitLab and Jira integrations as well. @ehsandeep @Ice3man543 what do you think?

@revblock
Copy link
Contributor Author

@forgedhallpass I'm happy to do that, I can take a look this weekend and get it sorted 👍

@forgedhallpass
Copy link
Contributor

The only thing that we need to test out whether creating new labels are permitted through all the APIs or not.

@revblock
Copy link
Contributor Author

@forgedhallpass I've added the label to the GitLab and Jira reporters.

I've tested this against the cloud versions of both of these. Unfortunately, I don't have access to the on-prem versions to test against but as far as I'm aware the functionality is the same in both.

One thing I did notice testing this was the example issue-tracker-config.yaml for GitLab isn't correct. It says project-id which is right for GitLab but in the code it's still looking for ProjectName so it doesn't seem to work. I'll raise this as a seperate issue though.

Thanks,

@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Status: Completed Nothing further to be done with this issue. Awaiting to be closed. labels Sep 21, 2021
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Sep 25, 2021
@ehsandeep ehsandeep merged commit b984f7d into projectdiscovery:dev Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] GitHub Reporting should add severity as labels
4 participants