feat: expose WaitVisible method from the rod library

[pmareke]

Fixes #1096

To-Do:

• Add new Action called ActionWaitVisible
• Add the implementation for ActionWaitVisible

Signed-off-by: pedro.lopez.mareque@gmail.com

[pmareke]

Also do I need to add one test for this action? Done!

[forgedhallpass]

Could you please also add a negative test scenario where the timeout expires and the element is not found? Have you also tested it with a headless template?

[pmareke]

Could you please also add a negative test scenario where the timeout expires and the element is not found? Have you also tested it with a headless template?

I added the timeout test but I don't know what do you mean with a headless template, can you give some example?

[forgedhallpass]

@pmareke Thank you for your contribution!

I added the timeout test but I don't know what do you mean with a headless template, can you give some example?

1. By timeout I meant an optional parameter for the WaitVisible method. I've added it in c0ef419, where I've also extracted the duplicated logic from your test.

2. Nuclei is a vulnerability scanner that relies on rules defined in yaml templates.
   I've added an example in the ticket, see [feature] Add/Expose Headless action that waits until an element appears #1096 (comment)

[pmareke]

@pmareke Thank you for your contribution!

I added the timeout test but I don't know what do you mean with a headless template, can you give some example?

1. By timeout I meant an optional parameter for the WaitVisible method. I've added it in c0ef419, where I've also extracted the duplicated logic from your test.
2. Nuclei is a vulnerability scanner that relies on rules defined in yaml templates.
   I've added an example in the ticket, see [feature] Add/Expose Headless action that waits until an element appears #1096 (comment)

Thanks to you @forgedhallpass, I really enjoyed the PR!

[forgedhallpass]

Thanks to you @forgedhallpass, I really enjoyed the PR!

Very glad to hear that! I am looking forward to your future contributions in case you decide to do so. Let me know if your eyes catch something or if you have new ideas. Thanks again for your efforts :)