-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing examples in headless engine protocol actions #1108
Add missing examples in headless engine protocol actions #1108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- solve the linter issue
- Optional: conflict that was introduced by my refactor.
- Optional: you could try to follow the same approach to remove duplicated code, otherwise I will do it myself later on.
Sure, I'll give it a try! |
Regarding this one I'm not quite sure what do you mean. I can see yo created a privaste helper method to use in both |
@pmareke I've extracted the common logic into a separate method so that I can re-use it instead of duplicating the code. The advantage is that this way the the test cases are easier to read and if later on, they'd require adjusting, they would only have to be modified in one place. But as I said, since it's test code, this is rather a challange then a requirement :-) The PR will be approved without it as well. |
Ou no no it's perfect, the only place where we have another |
@forgedhallpass Refactored |
Fixes #1102
Done:
trace
to true but it's private)Signed-off-by: pedro.lopez.mareque@gmail.com