Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to read tcp data stream till the end #1111

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Oct 12, 2021

This PR allows to merge multiple read operations into a unique template-read defined one. From the associated issue:

{
  "data": "\ufffd\ufffd\u0001\ufffd\ufffd\u0003",
  "hex": "fffb01fffb03",
  "response": true
}
{
  "data": "Modbus/TCP to RTU Bridge\r\u0000\nSerial Number 5138264  MAC address 00204A519578\n\r\u0000Software version V2.6.0.0B1 (131112) DLX\r\u0000\n\n\r\u0000Press Enter for Setup Mode \n\r\u0000",
  "hex": "4d6f646275732f54435020746f20525455204272696467650d000a53657269616c204e756d626572203531333832363420204d41432061646472657373203030323034413531393537380a0d00536f6674776172652076657273696f6e2056322e362e302e30423120283133313131322920444c580d000a0a0d00507265737320456e74657220666f72205365747570204d6f6465200a0d00",
  "response": true
}

Before:

id: test

info:
  name: test
  author: pdteam
  severity: info
  tags: network

network:
  - host:
      - "{{Hostname}}"

    read-size: 1024

would read \ufffd\ufffd\u0001\ufffd\ufffd\u0003

After:

id: test

info:
  name: test
  author: pdteam
  severity: info
  tags: network

network:
  - host:
      - "{{Hostname}}"

    read-all: true

would read \ufffd\ufffd\u0001\ufffd\ufffd\u0003Modbus/TCP to RTU Bridge\r\u0000\nSerial Number 5138264 MAC address 00204A519578\n\r\u0000Software version V2.6.0.0B1 (131112) DLX\r\u0000\n\n\r\u0000Press Enter for Setup Mode \n\r\u0000

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 12, 2021
@Mzack9999 Mzack9999 linked an issue Oct 12, 2021 that may be closed by this pull request
@ehsandeep ehsandeep self-assigned this Oct 15, 2021
@Ice3man543 Ice3man543 merged commit aa8b15c into dev Oct 25, 2021
@Ice3man543 Ice3man543 deleted the issue-829-network-read-all branch October 25, 2021 11:58
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: In-review 🔨 labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown chars in network response breaking matcher engine
3 participants