Improving gbk detection coverage #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Bug
Mzack9999
added
the
Status: In Progress
Mzack9999
removed
the
Status: In Progress
ehsandeep
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
echo http://58.214.233.117:8080 | ./nuclei -t test.yaml
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ 2.5.3-dev
projectdiscovery.io
[WRN] Use with caution. You are responsible for your actions.
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
[INF] Using Nuclei Engine 2.5.3-dev (development)
[INF] Using Nuclei Templates 8.5.9 (latest)
[INF] Using Interactsh Server https://interactsh.com
[INF] Templates added in last update: 37
[INF] Templates loaded for scan: 1
[test-gbk] [http] [info] http://58.214.233.117:8080 [电子文档安全管理系统]
Ice3man543
approved these changes
Oct 16, 2021
ehsandeep
added
Status: Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve gbk encoding detection by adding
gb18030and move the detection code into a helper function